Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeutil package #186

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Add timeutil package #186

merged 1 commit into from
Aug 1, 2023

Conversation

AntonioMA
Copy link
Contributor

Description

Implements an alias for time.Duration that automatically marshals/unmarshals to JSON in human readable form.

Checklist:

  • The make x command has been run successfully without any error or warning.
  • Any new code line is covered by unit tests and the coverage has not dropped.
  • Any new code follows the style guidelines of this project.
  • The code changes have been self-reviewed.
  • Corresponding changes to the documentation have been made.
  • The version has been updated in the VERSION and examples/service/go.mod files.

Type of change:

  • Bug fix (non-breaking change which fixes an issue) → The patch number in the VERSION file has been increased.
  • New feature (non-breaking change which adds functionality) → The minor number in the VERSION file has been increased.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) → This requires a major version release.
  • Automation.
  • Documentation.
  • Example.
  • Testing.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5728231507

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5725379768: 0.0%
Covered Lines: 4984
Relevant Lines: 4984
💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nicolaasuni-vonage nicolaasuni-vonage merged commit 6d3f399 into main Aug 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaasuni-vonage nicolaasuni-vonage nicolaasuni-vonage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntonioMA @coveralls @nicolaasuni-vonage